Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Added link for automated tests files in DOCUMENTATION_GUIDELINES.md #1008

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

Yash-Pratapwar
Copy link
Contributor

Fixes

Fixes #992 by @Yash-Pratapwar

Description

This PR adds the link for automaed tests files in DOCUMENTATION_GUIDELINES.md

Testing Instructions

Go to DOCUMENTATION_GUIDELINES.md
Navigate to How to Start Contributing
Click on the link in the 3rd point under How to Start Contributing
See the fix.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Yash-Pratapwar Yash-Pratapwar requested a review from a team as a code owner November 15, 2022 07:41
@openverse-bot openverse-bot added 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed labels Nov 15, 2022
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation change looks fine. Dependency management files shouldn't be ignored in VCS.

.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the links, @Yash-Pratapwar! I'm approving on the condition that you fix the .gitignore file @dhruvkb mentioned.

@Yash-Pratapwar
Copy link
Contributor Author

Yash-Pratapwar commented Nov 15, 2022 via email

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Zack Krida <[email protected]>
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you and congrats on your first contribution!

@AetherUnbound AetherUnbound dismissed dhruvkb’s stale review November 15, 2022 18:05

Changes were addressed

@AetherUnbound AetherUnbound merged commit ef6cd42 into WordPress:main Nov 15, 2022
@Yash-Pratapwar
Copy link
Contributor Author

@AetherUnbound Thank you!

@Yash-Pratapwar Yash-Pratapwar deleted the issue_992 branch November 19, 2022 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link for automated tests file broken in DOCUMENTATION_GUIDELINES.md
6 participants