This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Added link for automated tests files in DOCUMENTATION_GUIDELINES.md #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
📄 aspect: text
Concerns the textual material in the repository
🛠 goal: fix
Bug fix
🟩 priority: low
Low priority and doesn't need to be rushed
labels
Nov 15, 2022
dhruvkb
previously requested changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation change looks fine. Dependency management files shouldn't be ignored in VCS.
obulat
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the links, @Yash-Pratapwar! I'm approving on the condition that you fix the .gitignore
file @dhruvkb mentioned.
Alright, will remove them from git ignore.
…On Tue, Nov 15, 2022, 20:46 Madison Swain-Bowden ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitignore
<#1008 (comment)>
:
> +Pipfile
+Pipfile.lock
For more context, these two files are used for defining and locking our
dependencies and are required for our project!
—
Reply to this email directly, view it on GitHub
<#1008 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APWNCAXG7KRPFWRAI7AHUITWIOSLPANCNFSM6AAAAAASAUCOS4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
zackkrida
reviewed
Nov 15, 2022
Co-authored-by: Zack Krida <[email protected]>
AetherUnbound
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you and congrats on your first contribution!
@AetherUnbound Thank you! |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
📄 aspect: text
Concerns the textual material in the repository
🛠 goal: fix
Bug fix
🟩 priority: low
Low priority and doesn't need to be rushed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #992 by @Yash-Pratapwar
Description
This PR adds the link for automaed tests files in DOCUMENTATION_GUIDELINES.md
Testing Instructions
Go to DOCUMENTATION_GUIDELINES.md
Navigate to How to Start Contributing
Click on the link in the 3rd point under How to Start Contributing
See the fix.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin